OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3k stars 3.16k forks source link

Tag viewer broken for RTSTRUCT series #2122

Closed fedorov closed 3 years ago

fedorov commented 3 years ago

I get the below when I try to open the following:

Study: 1.3.6.1.4.1.14519.5.2.1.1706.4009.192455081946878476141947586891 Series: 1.3.6.1.4.1.14519.5.2.1.1706.4009.528051917894993735599041861497

It also appears to be broken in this way for every RTSTRUCT series I tried.

image

pieper commented 3 years ago

I can reproduce that. Here's a sandbox link: https://idc-sandbox-000.firebaseapp.com/projects/idc-dev-etl/locations/us-central1/datasets/idc_tcia_mvp_wave0/dicomStores/idc_tcia/study/1.3.6.1.4.1.14519.5.2.1.1706.4009.192455081946878476141947586891

Drag RTSTRUCT to layout, pick tag viewer, pick the struct from the dropdown menu to trigger stack trace: image

igoroctaviano commented 3 years ago

I get the below when I try to open the following:

Study: 1.3.6.1.4.1.14519.5.2.1.1706.4009.192455081946878476141947586891 Series: 1.3.6.1.4.1.14519.5.2.1.1706.4009.528051917894993735599041861497

It also appears to be broken in this way for every RTSTRUCT series I tried.

image

Looks like ReferencedSOPInstanceUID and ReferencedSOPClassUID have undefined values in some depth so i have added a check to only include valid sequence values: https://github.com/OHIF/Viewers/pull/2187

fedorov commented 3 years ago

Now if I try to open the study mentioned in the original issue, I get this error:

image

https://testing-viewer.canceridc.dev/viewer/1.3.6.1.4.1.14519.5.2.1.1706.4009.192455081946878476141947586891

igoroctaviano commented 3 years ago

Now if I try to open the study mentioned in the original issue, I get this error:

image

https://testing-viewer.canceridc.dev/viewer/1.3.6.1.4.1.14519.5.2.1.1706.4009.192455081946878476141947586891

@Punzo fixed here: https://github.com/OHIF/Viewers/pull/2207

Punzo commented 3 years ago

perfect I'll test https://github.com/OHIF/Viewers/pull/2207 now