search

OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.1k stars 3.26k forks source link

Secondary capture colour image does not render on v3-demo #2788

Closed anthonyjang closed 11 months ago

anthonyjang commented 2 years ago

I am running v3-demo on https://v3-demo.ohif.org/local and load attached sample file and having following display. OHIFViewer

Please refer to the attached sample dicom file "colortest1-1.dcm", unzip from colortest1-1.zip. colortest1-1.zip

s2ramana commented 2 years ago

It is easy to reproduce by dragging the sample DICOM object attached by Anthony into v3-demo URL. By looking at the way it is rendering, it is as if the image is not being recognized as a color image even though samples per pixel is 3 and photometric interpretation is set to YBR_RCT.

swederik commented 2 years ago

Thanks for the report this is very helpful!

s2ramana commented 2 years ago

@swederik will the integration of Cornerstone 3D into OHIF fix issues like this or will the rendering of 2D images be unchanged? I looked at the Cornerstone 3D examples and if there was an example where you could drag and drop a local image, it would be useful to see what the behavior is.

swederik commented 2 years ago

My guess is that it's a metadata issue in OHIF or maybe in the WADO image loader. So I don't think the change to cs3d will fix it by itself, but we will make a note to look into it.

s2ramana commented 2 years ago

@swederik I agree that it is likely a metadata issue. It looks similar to the issue reported in #2790 from its appearance. What is the easiest way to debug Cornerstone from OHIF? This will help in identifying the metadata that it doesn't like. Do I need to rebuild Cornerstone to be not minified? My guess is that this is likely a simple issue to fix so I wanted to investigate it further.

RoshniPal commented 2 years ago

@s2ramana Turns out the JSON structure mentioned here render's the image correctly. However, issue of viewing all the frames of dicom image still persists. Additionally, I also observed issue rendering the image when the photometric interpretation tag's value is YBR_FULL_422 and it works with YBR_FULL or RGB.

sedghi commented 11 months ago

Please review the latest code in the master branch. I am confident that this issue has been resolved. If it persists, kindly reopen the issue with updated details.

Try viewer-dev.ohif.org instead of viewer.ohif.org Our viewer.ohif.org is deployed from release branch while viewer-dev.ohif.org is our master branch Read more about branch explanations here https://docs.ohif.org/development/getting-started#developing