OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.08k stars 3.25k forks source link

[Bug] OHIF v3 can't display dicom with jpeg anymore using /local #3436

Closed blabdouze closed 1 year ago

blabdouze commented 1 year ago

Describe the Bug

Since the migration to the dicom-image-loader loader, OHIF can't display dicom images with jpeg anymore. Trying to do so will raise the following error :

Uncaught (in promise) TypeError: Cannot assign to read only property 'prototype' of function 'function DedicatedWorkerGlobalScope() { [native code] }'
    at jpeg.js:564:15
    at 945 (jpeg.js:29:17)
    at o (bootstrap:19:32)
    at o.t (create fake namespace object:10:23)

Steps to Reproduce

  1. Try to display a local DICOM with an image in jpg. (e.g. use https://viewer-dev.ohif.org/localbasic)
  2. Open console to see the error

The current behavior

Image is not displayed

The expected behavior

Image is displayed

OS

Windows 10

Node version

v18.15.0

Browser

Chrome, Firefox

jbocce commented 1 year ago

@blabdouze thank you for reporting this. However, I have not been able to reproduce this problem. Would it be possible for you to provide an anonymized DICOM file(s) that demonstrates the problem? Thanks.

blabdouze commented 1 year ago

Sure you'll find bellow a sample with the images that doesn't work :

out.zip

They work fine with the v2 and other viewers so I don't this this is specific to this batch of data.

Thanks !

jbocce commented 1 year ago

Thanks @blabdouze. However it works for me using either/both Orthanc and dcm4chee as the data source. What data source are you using?

image

blabdouze commented 1 year ago

I use both local and JSON data source :

image

I've tried the demo at https://v3-demo.ohif.org and the latest build.

This happens on both chrome and firefox (latest version)

jbocce commented 1 year ago

@blabdouze, Ah ok, I see it using local. Thanks so much.

sedghi commented 1 year ago

most likely a fix here https://github.com/cornerstonejs/cornerstone3D/pull/674, can you try after the package is published?

blabdouze commented 1 year ago

It seems to work fine with version 1.4.1 of conerstone, thanks !