search

OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.06k stars 3.23k forks source link

[Bug] When Create Report for Measurements fails, all measurements are lost #3944

Open tzuccher opened 6 months ago

tzuccher commented 6 months ago

Describe the Bug

Added multiple measurements on multiple viewports for a study. When Create Report is selected and fails, all of the measurements created are lost

Steps to Reproduce

  1. Select study and the Basic Viewer button

  2. Went into 2x2 grid layout and created multiple measurements on all viewports image

  3. Select the Create Report button from the measurements panel

  4. Entered report name: test & saved = create report request failed message appears in lower right corner

  5. All measurements on the viewport & images are gone as well as the measurements in the right side measurements panel image

The current behavior

measurements lost when create report is selected and fails

The expected behavior

measurements should be retained when create report selection fails so that the user does not have to recreate them again

OS

MacBook Pro - Sonoma 14.1.1

Node version

unknown

Browser

Chrome v121

tzuccher commented 6 months ago

This was reproducible in the OHIF dev version (https://viewer-dev.ohif.org/): 3.8.0-beta.53, Commit hash: 5bba98ed848bdf46b5ba4fc4708527cced3308b5

james-hanks commented 3 months ago

Fix to keep existing annotations if save fails for any reason (including external)