search

OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.35k stars 3.37k forks source link

Loading an SR with annotations after loading a DICOM Seg will cause OHIF to become unresponsive (3.9.14) [Bug] #4159

Open BrandonDatUHN opened 5 months ago

BrandonDatUHN commented 5 months ago

Describe the Bug

If you load up an image set with a DICOM SR of saved OHIF annotations they will load fine.
image If you then load a SEG saved on the same series that will load fine too. image But if you try and load the SR after the SEG (or a second time once the seg is loaded) OHIF (and chrome) will become unresponsive. image

Steps to Reproduce

There are no image sets in the OHIF DEV Viewer Demo with an SR of saved annotations and a SEG or RTstruct.

I've created the screen shots above using https://viewer-dev.ohif.org/viewer/dicomlocal?StudyInstanceUIDs=2.16.840.1.114362.1.12114306.25269253871.663129508.995.565

You can download it here https://fileshare.uhn.ca/download/dae7eb16-b2e9-4fbe-b63f-7071699abe22 Please note that this file upload will expire in 30 days.

1) Load the image set in Basic Mode 2) Drag the SR into the main frame (3 circular annotations appear) 3) Drag the SEG into the main frame (it will render) 4) drag the SR into the main frame (OHIF will Hang)

Alternate

1) Load the image set in Basic Mode 2) Drag the SEG into the main frame (it will render) 3) drag the SR into the main frame (OHIF will Hang)

The current behavior

Loading a DICOM SEG or RT STRUCT forces the view to switch to 3D. Loading the SR based annotations after that appears to crash.

The expected behavior

SRs should load properly on the 3D viewer after a Seg has loaded. You can create new annotations after loading a SEG so the 3D window seems to handle it however it will crash when you try and export the report (can't do this on the demo but it does hang on 3.9.14 on QIPCM)

OS

Win 11

Node version

OHIF DEMO version

Browser

Version 125.0.6422.61 (Official Build) (64-bit)

BrandonDatUHN commented 5 months ago

Download password - landmark

jenny-hm-lee commented 5 months ago

Notes from OHIF office hour: Issue comes from the CornerstoneSRViewport because its a stack viewport, and when a SEG is loaded it converts to volume. We should be able to load SR first then SEG, right now this is also not working, investigate and fix.