OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3k stars 3.16k forks source link

[Bug] Overlay fails on viewports when used with hanging protocols #4168

Open haldawe2 opened 1 month ago

haldawe2 commented 1 month ago

Describe the Bug

When using hanging protocols, and going into a study from the study browser or from a direct link, sometimes some or all of the overlays fail to render with a console error. Refreshing the page or going from one stage to another seems to work fine all the time.

image

image

Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node. at http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:1998:29 at Array.forEach () at clearUntouched (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:1995:85) at draw (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:1100:22) at AnnotationRenderingEngine._triggerRender (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:44785:58) at AnnotationRenderingEngine._renderFlaggedViewports (http://localhost:3000/vendors-node_modules_cornerstonejs_tools_dist_esm_store_index_js.js:44713:26)

Steps to Reproduce

  1. Get this DX in a server. DX.zip
  2. Open the study with at least 1x2 HP (&hangingProtocolId=@ohif/mnGrid) from the study browser or using a direct link in a new tab

The current behavior

Sometimes the overlay fails to render

The expected behavior

Always renders the overlay

OS

Windows 10

Node version

20.11.1

Browser

Chrome 125.0.6422.77

sedghi commented 1 month ago

Thanks, we will look

wayfarer3130 commented 2 weeks ago

Fixed in https://github.com/OHIF/Viewers/pull/4224