OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.12k stars 3.29k forks source link

fix(pdf-viewport): Allow Drag and Drop on PDF Viewport #4225

Closed Michael-Andersen closed 3 months ago

Michael-Andersen commented 3 months ago

Context

If you have a study with a multiple series, at least one of which is DOC modality PDF and you load the PDF, you won't be able to drag and drop a new series into the viewport. See issue: https://github.com/OHIF/Viewers/issues/4060

Changes & Results

This change listens for the Drag Event and disables the typical mouse events associated with the PDF viewer which otherwise prevent the drag and drop. In case of a partial drag that is not completed the user can click on the PDF to reactive the mouse events (so that scrolling the pdf will work again).

Testing

Checklist

PR

Code

Public Documentation Updates

Tested Environment

netlify[bot] commented 3 months ago

Deploy Preview for ohif-dev ready!

Name Link
Latest commit 425a09ebb5710030283d629e04171b0e50d4a461
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/666c75277d7acd000855b4ae
Deploy Preview https://deploy-preview-4225--ohif-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit 425a09ebb5710030283d629e04171b0e50d4a461
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/666c7527619dfe00088509c3
Deploy Preview https://deploy-preview-4225--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Michael-Andersen commented 3 months ago

@sedghi this is a fix for https://github.com/OHIF/Viewers/issues/4060

maybe a little hacky but gets at the heart of the issue I think