OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
2.98k stars 3.12k forks source link

feat(HP): Frame View HP #4235

Closed IbrahimCSAE closed 1 week ago

IbrahimCSAE commented 2 weeks ago

Context

Source of idea: https://santesoft.com/win/sante-dicom-viewer-lite/sante-dicom-viewer-lite.html

image image image image
netlify[bot] commented 2 weeks ago

Deploy Preview for ohif-dev ready!

Name Link
Latest commit 0340b56db73295f86a9880afe86a1e2cdb65f4a4
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6673760b92484c000898be3e
Deploy Preview https://deploy-preview-4235--ohif-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit 0340b56db73295f86a9880afe86a1e2cdb65f4a4
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6673760b7c907f0008c4cdcb
Deploy Preview https://deploy-preview-4235--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 2 weeks ago

Passing run #4103 ↗︎

0 44 2 0 Flakiness 0

Details:

Merge branch 'master' into feat/random
Project: Viewers Commit: 0340b56db7
Status: Passed Duration: 05:27 💡
Started: Jun 20, 2024 12:35 AM Ended: Jun 20, 2024 12:40 AM

Review all test suite changes for PR #4235 ↗︎

IbrahimCSAE commented 2 weeks ago

needs an icon if we want this in the layout selector

deathknight0718 commented 5 days ago

@IbrahimCSAE protocolMatchingRules is undefined. so, When using segmentation mode, the following code generates an error.

  findMatchByStudy(study, options) {
    const matched = [];

    this.protocols.forEach(protocol => {
      // Clone the protocol's protocolMatchingRules array
      // We clone it so that we don't accidentally add the
      // numberOfPriorsReferenced rule to the Protocol itself.
      console.log(protocol);
      let rules = protocol.protocolMatchingRules.slice(); // FAILED