OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
2.98k stars 3.12k forks source link

fix: Use correct external URL for rendered responses with relative URI #4236

Closed wayfarer3130 closed 1 week ago

wayfarer3130 commented 1 week ago

Context

For relative URI's in the metadata for DICOMweb, the standard says you are supposed to use the path provided. However, when we use the direct URL provided for computing paths, the wrong path is chosen, based on the wrong datasource name. This PR uses the correct relative paths for bulkdata whether that is doing rendered display or otherwise.

Changes & Results

Testing

Open up the deploy preview (or e2e config), and use datasources=ohif3 Query for "Horse" as the patient name Display the vidoe The video should display.

Checklist

PR

Code

Public Documentation Updates

Tested Environment

netlify[bot] commented 1 week ago

Deploy Preview for ohif-dev ready!

Name Link
Latest commit 0c238f89b84df2ad9484bd335c2edd36d3fb2019
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6670847349049000086d9590
Deploy Preview https://deploy-preview-4236--ohif-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 week ago

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit 0c238f89b84df2ad9484bd335c2edd36d3fb2019
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/667084732af905000749d26c
Deploy Preview https://deploy-preview-4236--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

wayfarer3130 commented 1 week ago

@igoroctaviano - could you test this against the IDC bulkdata responses? I know you added a change to the path, and I think I have that all correct, but I don't have the remote system to test against.

cypress[bot] commented 1 week ago

Passing run #4087 ↗︎

0 44 2 0 Flakiness 0

Details:

fix: Use correct external URL for rendered responses with relative URI
Project: Viewers Commit: 0c238f89b8
Status: Passed Duration: 05:02 💡
Started: Jun 17, 2024 6:56 PM Ended: Jun 17, 2024 7:01 PM

Review all test suite changes for PR #4236 ↗︎

wayfarer3130 commented 1 week ago

Tested - works right on the deploy preview https://deploy-preview-4236--ohif-dev.netlify.app/viewer/ohif3?StudyInstanceUIDs=2.25.96975534054447904995905761963464388233