[Bug] useBulkDataURI disapeared ?

OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages

https://docs.ohif.org/

MIT License

2.98k stars 3.12k forks source link

[Bug] useBulkDataURI disapeared ? #4258

Open salimkanoun opened 1 week ago

salimkanoun commented 1 week ago

Describe the Bug

useBulkDataURI config param appear only in local_orthanc.js and configurationFiles.md It doesn't seems to be used elsewhere in the code, it is a legacy parameter to be removed?

Steps to Reproduce

none

The current behavior

none

The expected behavior

none

OS

none

Node version

none

Browser

none

sedghi commented 2 days ago

I think you need to do this now?

bulkDataURI: { enabled: true,

@wayfarer3130

wayfarer3130 commented 1 day ago

Yes, the useBulkDataURI has disappeared in favour of more complete configuration control to deal with various situations where the bulkdata uri is non-standard. Please use the bulkDataURI: { enabled: true, ... }

salimkanoun commented 22 hours ago

Ok i made a PR https://github.com/OHIF/Viewers/pull/4272 to remove this unused variable