fix(orthanc): Correct bulkdata URL handling and add configuration example PDF

wayfarer3130 commented 5 days ago

Context

Orthanc responds with an invalid URL for bulkdata, and wasn't sure about the configuration for retrieving bulkdata for PDF display. This PR adds the ability to fix a broken URL when it is prefixed by a fixed string, and adds an example orthanc.js configuration file.

Fixing this https://github.com/OHIF/Viewers/issues/4256

Changes & Results

Changed fixBulkDataURI to replace a startsWith setting with another fixed string. Added orthanc.js as an example file

Testing

Run a local orthanc server, and modify the webpack-pwa.js file to proxy data to it and then store an SR. Ensure you can see the SR.

Bonus testing: Store a video file to orthanc and demonstrate that you can show the video.

Checklist

PR

[] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments, etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API additions or removals.

Tested Environment

[] OS:
[] Node version:
[] Browser:

netlify[bot] commented 5 days ago

Deploy Preview for ohif-platform-docs canceled.

Name	Link
Latest commit	23f3c50968af5eb3bcb41b0966779004b3bd74b3
Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/667c3c61720eb900087ee413

netlify[bot] commented 5 days ago

Deploy Preview for ohif-dev ready!

Name	Link
Latest commit	23f3c50968af5eb3bcb41b0966779004b3bd74b3
Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/667c3c61f1e9290008630e0d
Deploy Preview	https://deploy-preview-4262--ohif-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 5 days ago

Passing run #4128 ↗︎

0

44

2

0

Details:

Update the local orthanc example
Project: Viewers	Commit: `23f3c50968`
Status: Passed	Duration: 05:26 💡
Started: Jun 26, 2024 4:20 PM	Ended: Jun 26, 2024 4:25 PM

Review all test suite changes for PR #4262 ↗︎

sedghi commented 5 days ago

@amazy

amazy commented 5 days ago

@sedghi @wayfarer3130 I confirm this solves our issue in our test setup.

Huge thanks for your collaboration, this will make a lot of Orthanc users happy !

OHIF / Viewers