OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.12k stars 3.29k forks source link

fix: webpack import bugs showing warnings on import #4265

Closed wayfarer3130 closed 2 months ago

wayfarer3130 commented 3 months ago

relies on https://github.com/OHIF/Viewers/pull/4182 to be merged

Context

This change moves the dynamic import of modules into the plugin config so that they can be configured as desired. Then, this is used to import peer dependencies for cornerstone.

Changes & Results

Testing

Checklist

PR

Code

Public Documentation Updates

Tested Environment

netlify[bot] commented 3 months ago

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit 33b8b2dd790efd4c995ceb428405012ce06421a9
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66883225c07cc70008bee23b
Deploy Preview https://deploy-preview-4265--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for ohif-dev ready!

Name Link
Latest commit 33b8b2dd790efd4c995ceb428405012ce06421a9
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66883225bab819000825a2fe
Deploy Preview https://deploy-preview-4265--ohif-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 3 months ago

Passing run #4160 ↗︎

0 44 2 0 Flakiness 0

Details:

migration guide for peerImport/external libraries
Project: Viewers Commit: 33b8b2dd79
Status: Passed Duration: 05:38 💡
Started: Jul 5, 2024 6:14 PM Ended: Jul 5, 2024 6:20 PM

Review all test suite changes for PR #4265 ↗︎