OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.35k stars 3.37k forks source link

[DONT MERGE] Trying new cornerstone3d 2.0 with the recent release #4306

Closed sedghi closed 2 months ago

sedghi commented 3 months ago

Trying to migrate ohif to new upcoming cornerstone3D 2.0 with the migration guides from here https://github.com/cornerstonejs/cornerstone3D/pull/1400

Todo:

netlify[bot] commented 3 months ago

Deploy Preview for ohif-prod ready!

Name Link
Latest commit d6c4c68573098975f0da95417c090e254b6b4ed1
Latest deploy log https://app.netlify.com/sites/ohif-prod/deploys/66ccd7f04628d40007726797
Deploy Preview https://deploy-preview-4306--ohif-prod.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 3 months ago

Viewers    Run #4236

Run Properties:  status check failed Failed #4236  •  git commit d6c4c68573: was not that hard migration at least for basic render nice
Project Viewers
Branch Review feat/3.8-cs-next
Run status status check failed Failed #4236
Run duration 06m 25s
Commit git commit d6c4c68573: was not that hard migration at least for basic render nice
Committer Alireza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 42
View all changes introduced in this branch ↗︎


Tests for review

Failed  study-list/OHIFStudyList.spec.js • 1 failed test View Output Video
Test Artifacts
OHIF Study List > Desktop resolution > maintains Patient Name filter upon return from viewer Test Replay Screenshots Video
Failed  ImageConsistency.spec.js • 1 failed test View Output Video
Test Artifacts
CS3D Image Consistency and Quality > TG18 Resolution Test Displayed 1:1 Test Replay Screenshots Video