OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.12k stars 3.29k forks source link

fix(dicom): Update multiframe DICOM JSON parsing for correct image ID generation #4307

Closed igoroctaviano closed 2 months ago

igoroctaviano commented 2 months ago

Context

When loading a multiframe dicom json with multiple instances (each instance with its unique URL) OHIF was generating the image ids using just the first instance URL. Here I'm updating the parsing so it prioritizes the instances from the JSON file

Changes & Results

Testing

Checklist

PR

Code

Public Documentation Updates

Tested Environment

netlify[bot] commented 2 months ago

Deploy Preview for ohif-platform-docs canceled.

Name Link
Latest commit dd78da449674d7e32d66b94b601e4362592f9864
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66a3cbbe57cdf10008c01325
netlify[bot] commented 2 months ago

Deploy Preview for ohif-dev canceled.

Name Link
Latest commit dd78da449674d7e32d66b94b601e4362592f9864
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66a3cbbefa53ee0008b2028e
cypress[bot] commented 2 months ago

Passing run #4193 ↗︎

0 44 2 0 Flakiness 0

Details:

chore: Update DICOM JSON generator to support optional scheme parameter
Project: Viewers Commit: dd78da4496
Status: Passed Duration: 05:21 💡
Started: Jul 26, 2024 4:41 PM Ended: Jul 26, 2024 4:46 PM

Review all test suite changes for PR #4307 ↗︎