feat(SR): SCOORD3D point annotations support for stack viewports

OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages

https://docs.ohif.org/

MIT License

3.35k stars 3.37k forks source link

feat(SR): SCOORD3D point annotations support for stack viewports #4315

Closed igoroctaviano closed 1 month ago

igoroctaviano commented 3 months ago

Context

Support for SCOORD3D point annotations (just rendering / no hydration)
Support for SCT finding site (rendering labels to point and panel)
Update to untracked findings so the user can interact (jump to measurement)
Issue: https://github.com/OHIF/Viewers/issues/1215
https://github.com/cornerstonejs/cornerstone3D/pull/1446

Changes & Results

Testing

Checklist

PR

[] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments, etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API additions or removals.

Tested Environment

[] OS:
[] Node version:
[] Browser:

netlify[bot] commented 3 months ago

Deploy Preview for ohif-platform-docs ready!

Name	Link
Latest commit	bf5ea3aaf3f212c75bb0233a0cc05b6c87b940ab
Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/670fc77dde24330008c9144f
Deploy Preview	https://deploy-preview-4315--ohif-platform-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 months ago

Deploy Preview for ohif-dev ready!

Name	Link
Latest commit	bf5ea3aaf3f212c75bb0233a0cc05b6c87b940ab
Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/670fc77d7841da0009b0a4a2
Deploy Preview	https://deploy-preview-4315--ohif-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 3 months ago

Viewers Run #4358

Run Properties: Failed #4358 • bf5ea3aaf3: Merge branch 'master' of github.com:ohif/Viewers into feat/scoord3d-point-annota...

Project	`Viewers`
Run status	`Failed #4358`
Run duration	`02m 36s`
Commit	`bf5ea3aaf3: Merge branch 'master' of github.com:ohif/Viewers into feat/scoord3d-point-annota...`
Committer	`Igor Octaviano`
View all properties for this run ↗︎

Test results
Failures	`1`
Flaky	`0`
Pending	`2`
Skipped	`2`
Passing	`41`

Tests for review

cypress/integration/volume/MPR.spec.js • 1 failed test

View Output Video

Test		Artifacts
OHIF MPR > should render correctly the MPR		`Test Replay` `Screenshots` `Video`

igoroctaviano commented 2 months ago

@wayfarer3130 could you please review it and test using this SCOORD3D point? (local or dcm4chee) https://drive.google.com/drive/folders/1Zwk4KcbTbylilmk6U0byrxsDP1fO7UGx?usp=drive_link

The idea here is to be able to display the points on different series with stack and volume viewports. CS3D PR: https://github.com/cornerstonejs/cornerstone3D/pull/1446

igoroctaviano commented 1 month ago

@sedghi, could you please review this? If any changes or clean-ups are needed, I'll handle them based on your final feedback.

fedorov commented 1 month ago

Really happy to see this effort completed! Thank you @igoroctaviano and @sedghi for bringing it over the finish line! 🏆