OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.35k stars 3.37k forks source link

SmartScrollbar component to show cached slices #4340

Open Adithyan-Dinesh-Trenser opened 2 months ago

Adithyan-Dinesh-Trenser commented 2 months ago

Context

A Viewport scrollbar that shows the cached slices of the displayset loading in that viewport. Also, a feature was added to scroll only to the cached slices in normal scrolling operations. To force scrolling ( scrolling to uncached slices ) must press the Ctrl key when scrolling.

Changes & Results

Testing

Checklist

PR

Code

Public Documentation Updates

Tested Environment

netlify[bot] commented 2 months ago

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit b2e4b284125c81bec53dc1a4d22b0322a7683d0d
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66fe8c9b6f73b00008cf8795
Deploy Preview https://deploy-preview-4340--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 months ago

Deploy Preview for ohif-dev canceled.

Name Link
Latest commit b2e4b284125c81bec53dc1a4d22b0322a7683d0d
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66fe8c9b944c7700082d8bee
Adithyan-Dinesh-Trenser commented 2 months ago

Cc : @Ouwen

Ouwen commented 2 months ago

@sedghi is this something that could be in upstream?

sedghi commented 2 months ago

@Ouwen Hey guys, thanks, yes it can be. CCing our designer for this

@dan-rukas @james-hanks

dan-rukas commented 2 months ago

Hi everyone! I work as a UX designer on the OHIF team. This is amazing! Thank you for sharing! We would love to add this to OHIF. We are currently looking at some design updates that we'll want to apply here. I can take a look at those applied to this component at the end of this week (or early next) and share them here.

Thank you again! โค๏ธ

salimkanoun commented 2 months ago

Hi there, thanks for this nice addition,

I have a question about this statement

The SmartScrollbar is only available in stack viewport as the number of imagesIds and the number of slices may vary in 2d MPR viewports.

I wonder if it woundn't be possible to see things differently, rather then trying to mach the number of slice in the viewport consider the displayset loaded fraction.

The displayset has a known number of frames so it would be possible to display how many slice of the display set have been loaded and this could work for a volume viewport no matter of its orientation.

Maybe would need a bit different presentation. The actual vertical make sense for a stack viewport to display which slice is available.

Could this PR be extended to another overlay maybe a progress circle to show the fraction of laoaded display set in case of a volume viewport ?

sedghi commented 1 month ago

We were too busy with the rest of the component library, and still didn't have time to look at the design here, sorry about the delay

sedghi commented 1 week ago

We're sorry we couldn't include this in 3.9 due to other high priorities. We appreciate your patience and will review this, and give a design as soon as possible.