OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.12k stars 3.29k forks source link

fix(hps): turn off HP when switching to a common layout or a custom MxN grid. #4341

Closed IbrahimCSAE closed 1 month ago

IbrahimCSAE commented 1 month ago

This change lets users get out of the advanced HPs when they select a common layout or a custom grid.

netlify[bot] commented 1 month ago

Deploy Preview for ohif-dev ready!

Name Link
Latest commit d999ed83ed73263839d10377ccb994cf81848804
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/66c483e0a2230000094302d9
Deploy Preview https://deploy-preview-4341--ohif-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit d999ed83ed73263839d10377ccb994cf81848804
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/66c483e069384100082dd0eb
Deploy Preview https://deploy-preview-4341--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 1 month ago



Test summary

44 0 2 0


Run details

Project Viewers
Status Passed
Commit d999ed83ed
Started Aug 20, 2024 12:04 PM
Ended Aug 20, 2024 12:06 PM
Duration 02:45 💡
OS Linux Ubuntu -
Browser Chrome 127

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

sedghi commented 1 month ago

I don't think this change is ideal. The layout adjustment should use viewports from the viewer's current state, which may include advanced protocols. Resetting everything and randomly matching again introduces too much unpredictability.

Why do you want to alter this well-functioning behavior at this time?