OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.37k stars 3.39k forks source link

feat mammo hanging protocol #4445

Open narbek-abd opened 3 weeks ago

narbek-abd commented 3 weeks ago

Context

solves https://github.com/OHIF/Viewers/issues/2019

Changes & Results

Just added cc and mlo hanging protocols image

Testing

Just open some mammo studies with &hangingprotocolId=mgCC or mgMLO

Notes

  1. In our case i actually added "any" attribute just in case:
    
    seriesMatchingRules: [
    { weight: 2, attribute: "isLCC", constraint: { equals: { value: true } } },
    { weight: 1, attribute: "any", constraint: { equals: { value: true } } },
    ];

customAttributeRetrievalCallbacks = { ... any: { name: "any", callback: (displaySet) => true, }, ... };



2. In Deploy Preview below there is two mammo studies, but they don't have R-MLO instance it seems

### Checklist

#### PR

<!--
https://semantic-release.gitbook.io/semantic-release/#how-does-it-work

Examples:
Please note the letter casing in the provided examples (upper or lower).

- feat(MeasurementService): add ...
- fix(Toolbar): fix ...
- docs(Readme): update ...
- style(Whitespace): fix ...
- refactor(ExtensionManager): ...
- test(HangingProtocol): Add test ...
- chore(git): update ...
- perf(VolumeLoader): ...

You don't need to have each commit within the Pull Request follow the rule,
but the PR title must comply with it, as it will be used as the commit message
after the commits are squashed.
-->

- [x] My Pull Request title is descriptive, accurate and follows the
  semantic-release format and guidelines.

#### Code

- [x] My code has been well-documented (function documentation, inline comments,
  etc.)

#### Public Documentation Updates

<!-- https://docs.ohif.org/ -->

- [] The documentation page has been updated as necessary for any public API
  additions or removals.

#### Tested Environment

- [x] OS: Ubuntu ubuntu 22.04<!--[e.g. Windows 10, macOS 10.15.4]-->
- [x] Node version:  v21.7.3 <!--[e.g. 18.16.1]-->
- [x] Browser: Chrome, Firefox
  <!--[e.g. Chrome 83.0.4103.116, Firefox 77.0.1, Safari 13.1.1]-->

<!-- prettier-ignore-start -->
[blog]: https://circleci.com/blog/triggering-trusted-ci-jobs-on-untrusted-forks/
[script]: https://github.com/jklukas/git-push-fork-to-upstream-branch
<!-- prettier-ignore-end -->
netlify[bot] commented 3 weeks ago

Deploy Preview for ohif-dev ready!

Name Link
Latest commit d8e31fd82135dfb7a060e75a8a77fd393704eef0
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6721c4bd311852000803fd03
Deploy Preview https://deploy-preview-4445--ohif-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit d8e31fd82135dfb7a060e75a8a77fd393704eef0
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6721c4bd07b5db0008fd3f8d
Deploy Preview https://deploy-preview-4445--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sedghi commented 3 weeks ago

Thanks a lot!

wayfarer3130 commented 3 weeks ago

Could you start with hpMammo.ts and extend those hanging protocols?