feat: improve dicom tag browser

OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages

https://docs.ohif.org/

MIT License

3.37k stars 3.39k forks source link

feat: improve dicom tag browser #4451

Open pedrokohler opened 3 weeks ago

pedrokohler commented 3 weeks ago

Context

Addresses: https://github.com/OHIF/Viewers/issues/2372

Changes & Results

Collapse and expand items:

Deep search:

Use slider to navigate between series instances:

Testing

Checklist

PR

[] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.

Code

[] My code has been well-documented (function documentation, inline comments, etc.)

Public Documentation Updates

[] The documentation page has been updated as necessary for any public API additions or removals.

Tested Environment

[] OS:
[] Node version:
[] Browser:

netlify[bot] commented 3 weeks ago

Deploy Preview for ohif-platform-docs ready!

Name	Link
Latest commit	6e87c43e8ba650120c4307e6cc473c56df2f455e
Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/6723f5f36135a40008533669
Deploy Preview	https://deploy-preview-4451--ohif-platform-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 3 weeks ago

Deploy Preview for ohif-dev ready!

Name	Link
Latest commit	6e87c43e8ba650120c4307e6cc473c56df2f455e
Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/6723f5f3e6339500087b7fe5
Deploy Preview	https://deploy-preview-4451--ohif-dev.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

pedrokohler commented 3 weeks ago

@fedorov you can test it here: https://deploy-preview-4451--ohif-dev.netlify.app/

sedghi commented 3 weeks ago

Can you not touch the top header?

CleanShot 2024-11-01 at 09 08 25@2x

If you can afford not changing that we can merge in 3.9, otherwise it needs to go into the queue for design

sedghi commented 3 weeks ago

Also noticed that clicking on the (-) doesn't do anything CleanShot 2024-11-01 at 09 09 36@2x

pedrokohler commented 2 weeks ago

Also noticed that clicking on the (-) doesn't do anything

It doesn't because you searched for a nested item. In this case it won't. Try without searching and you'll see it works.

sedghi commented 2 weeks ago

Please revise this PR by tomorrow to include it in 3.9; otherwise, it will be moved to 3.10-beta. Thanks.

pedrokohler commented 1 week ago