search

OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.37k stars 3.39k forks source link

fix(ui) Study Browser small spacing changes #4469

Closed dan-rukas closed 2 weeks ago

dan-rukas commented 2 weeks ago

Context

Small design fixes for Study Thumbnails and Display set tooltip.

Changes & Results

PR

Code

Public Documentation Updates

Tested Environment

netlify[bot] commented 2 weeks ago

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit d46f4809d5e411d00cc8cb3988a872dfbe4dd385
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/672a354acd7c7600085aaf0e
Deploy Preview https://deploy-preview-4469--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for ohif-dev ready!

Name Link
Latest commit d46f4809d5e411d00cc8cb3988a872dfbe4dd385
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/672a354b371bf90008da59ec
Deploy Preview https://deploy-preview-4469--ohif-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 2 weeks ago

Viewers    Run #4392

Run Properties:  status check failed Failed #4392  •  git commit d46f4809d5: Study Browser spacing fixes
Project Viewers
Branch Review fix/study-spacing
Run status status check failed Failed #4392
Run duration 04m 10s
Commit git commit d46f4809d5: Study Browser spacing fixes
Committer Dan Rukas
View all properties for this run ↗︎
Test results
Tests that failed  Failures 11
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 20
Tests that passed  Passing 13
View all changes introduced in this branch ↗︎

Tests for review

Failed  customization/HangingProtocol.spec.js • 1 failed test View Output Video
Test Artifacts
OHIF HP > Should display 3 up Test Replay Screenshots Video
Failed  measurement-tracking/OHIFCornerstoneToolbar.spec.js • 1 failed test View Output Video
Test Artifacts
OHIF Cornerstone Toolbar > checks if all primary buttons are being displayed Test Replay Screenshots Video
Failed  volume/MPR.spec.js • 1 failed test View Output Video
Test Artifacts
OHIF MPR > should not go MPR for non reconstructible displaySets Test Replay Screenshots Video
Failed  customization/OHIFDoubleClick.spec.js • 1 failed test View Output Video
Test Artifacts
OHIF Double Click > Should double click each viewport to one up and back Test Replay Screenshots Video
Failed  measurement-tracking/OHIFMeasurementPanel.spec.js • 1 failed test View Output Video
Test Artifacts
OHIF Measurement Panel > checks if Measurements right panel can be hidden/displayed Test Replay Screenshots Video

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.