OHIF / Viewers

OHIF zero-footprint DICOM viewer and oncology specific Lesion Tracker, plus shared extension packages
https://docs.ohif.org/
MIT License
3.35k stars 3.37k forks source link

[OHI-865] [OHI-646] fix(viewport): set a minimum width of 5px on viewports to prevent them from turning black/ going into an unrecoverable state. #4517

Closed IbrahimCSAE closed 2 days ago

IbrahimCSAE commented 2 days ago

fixes https://github.com/OHIF/Viewers/issues/3159 fixes https://github.com/OHIF/Viewers/issues/4201

Context

Set a minimum width of 5px on viewports to prevent them from turning black/ going into an unrecoverable state.

before:

CleanShot 2024-11-15 at 02 01 45

after:

CleanShot 2024-11-15 at 02 00 49

netlify[bot] commented 2 days ago

Deploy Preview for ohif-platform-docs ready!

Name Link
Latest commit dbd243f5857bee8312682f48409bd573d97003c3
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/673758fd0c06a00008fccece
Deploy Preview https://deploy-preview-4517--ohif-platform-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 days ago

Deploy Preview for ohif-dev ready!

Name Link
Latest commit dbd243f5857bee8312682f48409bd573d97003c3
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/673758fdeca5370008329656
Deploy Preview https://deploy-preview-4517--ohif-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cypress[bot] commented 2 days ago

Viewers    Run #4435

Run Properties:  status check failed Failed #4435  •  git commit dbd243f585: Merge branch 'master' into fix/viewport-width
Project Viewers
Branch Review fix/viewport-width
Run status status check failed Failed #4435
Run duration 02m 10s
Commit git commit dbd243f585: Merge branch 'master' into fix/viewport-width
Committer Alireza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 43
View all changes introduced in this branch ↗︎


Tests for review

Failed  cypress/integration/customization/OHIFDoubleClick.spec.js • 1 failed test View Output Video
Test Artifacts
OHIF Double Click > Should double click each viewport to one up and back Test Replay Screenshots Video