Open sedghi opened 11 hours ago
netlify[bot]
commented
11 hours ago | Name | Link |
|---|---|
| Latest commit | |
| Latest deploy log | https://app.netlify.com/sites/ohif-prod/deploys/673fa719e900978c30b1a185 |
| Deploy Preview | https://deploy-preview-4540--ohif-prod.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
cypress[bot]
commented
10 hours ago 
Run #4444
Passed #4444
f310ef3921: fix| Project |
Viewers
|
| Branch Review |
fix/3p9-recovery-1
|
| Run status |
|
| Run duration | 02m 59s |
| Commit |
|
| Committer | sedghi |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
Fixes https://github.com/OHIF/Viewers/issues/4505 Fixes https://github.com/OHIF/Viewers/issues/4519 Fixes https://github.com/OHIF/Viewers/issues/4485 Fixes https://github.com/OHIF/Viewers/issues/4531 Fixes https://github.com/OHIF/Viewers/issues/4352 fixes potentially https://github.com/OHIF/Viewers/issues/4529
This pull request includes various changes across multiple files to improve functionality and fix issues in the project. The most important changes include fixes to image handling, improvements to metadata management, and updates to UI components.
Image Handling Improvements:
extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts: During a resize, the slice index is now removed to maintain the current position presentations. This is a temporary fix for a larger issue regarding the definition of slice index with slab thickness.extensions/cornerstone/src/utils/interleaveTopToBottom.ts: Simplified the image load request check using optional chaining.Metadata Management Enhancements:
extensions/default/src/DicomLocalDataSource/index.js: Added logic to handle multiframe instances by breaking each frame into a separate instance and creating new imageIds for each frame. [1] [2]platform/core/src/classes/MetadataProvider.ts: Added error handling for empty imageIds in several methods to ensure robustness. [1] [2] [3]UI Component Updates:
platform/ui-next/src/components/DataRow/DataRow.tsx: Simplified the rendering logic for data rows and updated the details section to handle both primary and secondary details more effectively. [1] [2]Miscellaneous Fixes:
extensions/default/src/DicomJSONDataSource/index.js: Corrected a typo in a comment regarding WADO-URI.modes/preclinical-4d/src/index.tsxandmodes/tmtv/src/index.ts: Updated volume labels to include units (ml). [1] [2]These changes collectively enhance the functionality, reliability, and maintainability of the codebase.