OHS-Hosting-Infrastructure / complaint-tracker

**This repo is currently not in active development.** Increasing visibility into complaint status by connecting data across the OHS ecosystem
Other
4 stars 0 forks source link

Add fake monitoring link to complaint #214

Closed jduss4 closed 2 years ago

jduss4 commented 2 years ago

Description of change

Copy pasted tta_activity_report into parallel monitoring_review files and then removed or ignored editing / deleting / error handling behavior. Would have liked to generalize more shared partials, but the TTA display_id behavior was just different enough I decided to leave it alone for now.

Also changed the faux-active model validation error handling in favor of a custom valid? method for the sake of making things make more sense to me, although I very much expect I have missed a good reason why TTA was set up that way.

Reorganized the UI a little to accommodate TTA + monitoring in the sidebar, slight refactor to JS.

Acceptance Criteria

As a program specialist I want to manually link a complaint to a monitoring review (in IT-AMS) So that I can see basic information about the review when I view a complaint

How to test

Start app, go to complaint detail page, add a new RAN id.

Issue(s)

Checklist

To be completed by the submitter:

To the Reviewer

This project is using Conventional Comments to give structure and context to PR comments. Please use these labels in your comments.

jduss4 commented 2 years ago

With TTA and RANs (note: cannot edit RANs)

image

Adding new of both at same time:

image

github-actions[bot] commented 2 years ago
Pa11y testing results ```yarn run v1.22.17 $ pa11y-ci Running Pa11y on 4 URLs: > http://localhost:8080/grantees/12345 - 0 errors > http://localhost:8080/complaints/pa11y-id - 1 errors > http://localhost:8080/complaints - 0 errors > http://localhost:8080 - 0 errors Errors in http://localhost:8080/complaints/pa11y-id: • id attribute value must be unique (https://dequeuniversity.com/rules/axe/3.5/duplicate-id?application=axeAPI) (#issue_id) ✘ 3/4 URLs passed error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ```
github-actions[bot] commented 2 years ago
Pa11y testing results ```yarn run v1.22.17 $ pa11y-ci Running Pa11y on 4 URLs: > http://localhost:8080/grantees/12345 - 0 errors > http://localhost:8080 - 0 errors > http://localhost:8080/complaints/pa11y-id - 1 errors > http://localhost:8080/complaints - 0 errors Errors in http://localhost:8080/complaints/pa11y-id: • id attribute value must be unique (https://dequeuniversity.com/rules/axe/3.5/duplicate-id?application=axeAPI) (#issue_id) ✘ 3/4 URLs passed error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ```