OHS-Hosting-Infrastructure / complaint-tracker

**This repo is currently not in active development.** Increasing visibility into complaint status by connecting data across the OHS ecosystem
Other
4 stars 0 forks source link

Sort table by issue creation #225

Closed rahearn closed 2 years ago

rahearn commented 2 years ago

Description of change

Load sorted data from the HSES api in both forward and reverse directions

This is utilizing the usa-table data-sortable for ease of styling. There is some weirdness (the sort button ends up getting put in the column twice, but you can only see one of them because they stack). I think the weirdness is ok given the time lines in play, but open to being told to do this more cleanly.

Acceptance Criteria

Turn real data on Table should load the first time with most recent data Click sort button Oldest issues now on page 1 Visit http://localhost:8080/complaints?sort=issueLastUpdated to see unsorted state

Issue(s)

Checklist

To be completed by the submitter:

To the Reviewer

This project is using Conventional Comments to give structure and context to PR comments. Please use these labels in your comments.

github-actions[bot] commented 2 years ago
Pa11y testing results ```yarn run v1.22.17 $ pa11y-ci Running Pa11y on 4 URLs: > http://localhost:8080 - 0 errors > http://localhost:8080/complaints/pa11y-id - 0 errors > http://localhost:8080/grantees/12345 - 0 errors > http://localhost:8080/complaints - 1 errors Errors in http://localhost:8080/complaints: • Buttons must have discernible text (https://dequeuniversity.com/rules/axe/3.5/button-name?application=axeAPI) (#main-content > div > div > table > thead > tr > th:nth-child(2) > button:nth-child(2))
github-actions[bot] commented 2 years ago
Pa11y testing results ```yarn run v1.22.17 $ pa11y-ci Running Pa11y on 4 URLs: > http://localhost:8080 - 0 errors > http://localhost:8080/grantees/12345 - 0 errors > http://localhost:8080/complaints/pa11y-id - 0 errors > http://localhost:8080/complaints - 1 errors Errors in http://localhost:8080/complaints: • Buttons must have discernible text (https://dequeuniversity.com/rules/axe/3.5/button-name?application=axeAPI) (#main-content > div > div > table > thead > tr > th:nth-child(2) > button:nth-child(2))