search

OHS-Hosting-Infrastructure / complaint-tracker

**This repo is currently not in active development.** Increasing visibility into complaint status by connecting data across the OHS ecosystem
Other
4 stars 0 forks source link

Monitoring delete / unlink #226

Closed jduss4 closed 2 years ago

jduss4 commented 2 years ago

Description of change

Adds deleting capabilities to monitoring reviews linked to a complaint. This imitates the TTA report activity so closely, you might even say that a lot of the partials / javascript are the same.

Acceptance Criteria

How to test

Navigate to complaint detail page, add a RAN ID, then unlink it, hopefully don't get an error.

Issue(s)

Checklist

To be completed by the submitter:

To the Reviewer

This project is using Conventional Comments to give structure and context to PR comments. Please use these labels in your comments.

github-actions[bot] commented 2 years ago
Pa11y testing results ```yarn run v1.22.17 $ pa11y-ci Running Pa11y on 4 URLs: > http://localhost:8080 - 0 errors > http://localhost:8080/grantees/12345 - 0 errors > http://localhost:8080/complaints/pa11y-id - 2 errors > http://localhost:8080/complaints - 0 errors Errors in http://localhost:8080/complaints/pa11y-id: • IDs used in ARIA and labels must be unique (https://dequeuniversity.com/rules/axe/3.5/duplicate-id-aria?application=axeAPI) (#unlink-modal-heading)

Are you sure you wan...

• IDs used in ARIA and labels must be unique (https://dequeuniversity.com/rules/axe/3.5/duplicate-id-aria?application=axeAPI) (#unlink-modal-description) ✘ 3/4 URLs passed error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ```
github-actions[bot] commented 2 years ago
Pa11y testing results ```yarn run v1.22.17 $ pa11y-ci Running Pa11y on 4 URLs: > http://localhost:8080 - 0 errors > http://localhost:8080/grantees/12345 - 0 errors > http://localhost:8080/complaints/pa11y-id - 1 errors > http://localhost:8080/complaints - 0 errors Errors in http://localhost:8080/complaints/pa11y-id: • IDs used in ARIA and labels must be unique (https://dequeuniversity.com/rules/axe/3.5/duplicate-id-aria?application=axeAPI) (#unlink-modal-description) ✘ 3/4 URLs passed error Command failed with exit code 2. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. ```