OHakimen / MorePeripherals

Adds new peripherals for CC:Tweaked
MIT License
8 stars 2 forks source link

Item Names / IDs #16

Closed crazyvinvin closed 1 year ago

crazyvinvin commented 1 year ago

This mod is amazing and we're making big use of it, however I would like to request one change:

Currently when requesting villager trades with tradingInterface.getTrades(), it returns a table looking like this: image

When checking items in a chest with cc tweaked, you get item names like: "minecraft:carrot", however the more peripherals interfaces return item names like: "item.minecraft.carrot" or "block.minecraft.melon", which makes it really difficult to compare.

Currently we have to hardcode every item name with it's corresponding "item.minecraft..." version of the item name. We could also find the string (like look for "carrot"), however this would go wrong with something like "minecraft:melon" ("item.minecraft.melon_slice" would give true)

Could you maybe change this, or add a config option or function parameter for this to be like "minecraft:carrot".

(We are playing on 1.19.2)

OHakimen commented 1 year ago

that is a problem that became a thing in the 1.19.2 port, because of the way item "path" is registered, i will try fixing it, thanks for showing me !

OHakimen commented 1 year ago

image managed to fix it :D

OHakimen commented 1 year ago

I'm going to push a update soon fixing this issue and the #15 issue :D

crazyvinvin commented 1 year ago

Thank you so much!