OHakimen / MorePeripherals

Adds new peripherals for CC:Tweaked
MIT License
8 stars 2 forks source link

Peripherals connected to network without modem #23

Closed crazyvinvin closed 1 year ago

crazyvinvin commented 1 year ago

Hey there, we found an issue with the peripherals connection to networks. We attachted a modem to a peripheral (in this case a turtle) and laid down a cable next to the computer, the computer sees this cable as a computer. Here are some images:

image image

When a modem is connected, this causes the computer to detect all peripherals on the network twice: image image

We also created an issue at the cc tweaked github page: https://github.com/cc-tweaked/CC-Tweaked/issues/1498

They also found the problem in the more peripherals mod and suggested a fix.

Many thanks, MCS Development

PS: Do you have any discord servers or twitter accs with updates about releases (in particularly 1.19.2 😉 )?

OHakimen commented 1 year ago

Hello, the code they reference is the cause of the issue, i was trying to dynamically allow peripherals to be recognised as such without registering them one by one, i didn't know it would cause problems, i'm working on a fix rn

OHakimen commented 1 year ago

Fixed in dev (i'm gonna roll out an update today)

and also responding to your PS, i currently don't post much about my modding anywere, mostly i do stuff and roll a version out, i'm present on the Minecraft Computer Mods Discord server tho, with the handle @hakimen

crazyvinvin commented 1 year ago

Thank you so much!