search

OI4 / oi4-oec-registry

An OI4-conform application which registers oncoming oi4-compatible participants (Applications/Devices) and displays several stats.
MIT License
1 stars 0 forks source link

UI: Namur-Symbols look like they are unequal in size #83

Open OI4-Hilscher opened 3 years ago

OI4-Hilscher commented 3 years ago

Some namur symbols look like they are smaller. This is not the case, every symbol has a fixed width and height, but due to their different form (triangle, circle etc.), some sizes may need to be adjusted manually in the code.

How can this be done: In the function displayNamurHealth in ExpansionPanelDetail.jsx:

Instead of returning always the same element, just with a different img src (like below) return <img style={{ verticalAlign: 'middle' }} src={this.state.namurLookup[status]} alt="Namur" height={height} width={width} />; we need to differentiate based on the "status" parameter and adjust the height and width img parameters

Konrad49 commented 1 year ago

I think it still looks like different sized symbols (even they aren't). We could implement a symbol based algorithm or we could simply rezise the symbols (if they are not used in different modes).