OISF / libhtp

LibHTP is a security-aware parser for the HTTP protocol and the related bits and pieces.
BSD 3-Clause "New" or "Revised" License
288 stars 115 forks source link

Http1 removetx 5921 v10 #417

Closed catenacyber closed 6 months ago

catenacyber commented 6 months ago

416 with dummy debug commit

victorjulien commented 6 months ago

Is the failing test above already enough proof?

catenacyber commented 6 months ago

Is the failing test above already enough proof?

Not yet, pushed another version passing tests

victorjulien commented 6 months ago

It aborts, but again only in the unix socket test.

catenacyber commented 6 months ago

Do you know which one of the 2 aborts ?

catenacyber commented 6 months ago

Does the unix socket test free transactions differently ?

Anyways, I think we should not get this optimization soon...

victorjulien commented 6 months ago

Does the unix socket test free transactions differently ?

It shouldn't matter.

Anyways, I think we should not get this optimization soon...

Agree. I will see if I can reproduce it manually after the releases next week.

catenacyber commented 6 months ago

Does the unix socket test free transactions differently ?

It shouldn't matter.

Sure, just trying to understand the issue, to reproduce and fix it. It seems to happen because transaction are not freed in order...

catenacyber commented 6 months ago

Replaced by https://github.com/OISF/libhtp/pull/418