[WIP] search box - Githubissues

OIT-UOG / specify-webportal-installer

fork of https://github.com/specify/webportal-installer

GNU General Public License v2.0

2 stars 0 forks source link

[WIP] search box #27

Closed Chovin closed 5 years ago

Chovin commented 5 years ago

closes #26

[x] express search on query param q=search_string
[ ] advanced search?
[ ] front-end (@vaniart can you help with this?)

I've added the ability to run a query on page load from url parameters. How should we build out on this feature?

as mentioned in https://github.com/OIT-UOG/specify-webportal-installer/issues/26#issuecomment-474697555 , we have may have a lot of freedom to work with this, maybe have a

[x] live popup of search results as they type it.

For now though, let's see if we can get something basic on the front page.

Chovin commented 5 years ago

This branch so far has the express search query string working. You can check the branch out to build the main page search bar out from. @vaniart let me know what else I can do to help with this task!

query

Also, What do you think about surrounding the user's search in wildcards *seach terms* by default?

@burdickdr what are your thoughts on what functionality you'd like to see in the main page search bar? I'm thinking big centered search bar kinda like https://www.gbif.org/ 's

Chovin commented 5 years ago

here's some https://www.sitepoint.com/14-jquery-live-search-plugins/ options. SemanticUI and Ajax Live Search look good? /shrug

Chovin commented 5 years ago

I've pushed a WIP using the Select2 library. If we go this direction we get a couple more todo items:

[x] determining which collection to search
- drop-down, radio/checkbox, or dropbown multiple-select?
- or search them all.. not as straight forward as might seem
[x] making it do something when pressing enter :P
- where would it go if searching over multiple collections?

@vaniart your input and help with the CSS would be greatly appreciated :) @burdickdr I'd love your input as well in what you'd like this feature to look like/do

Chovin commented 5 years ago

Added little select toggle for coral or fish. Thoughts? @vaniart could I get your help determining best styling/UI/UX?

coral or fish

fyi, there's some html in https://github.com/OIT-UOG/specify-webportal-installer/blob/d5e8709cc4cbe223c6568134deca2b8217c01e10/ROOT/js/search.js#L130-L147

Chovin commented 5 years ago

I feel like feature-wise this is deployable, we just need a little makeover of it now. @vaniart, when you have time, any help or pointers would be greatly appreciated :)

added:

selecting an item searches for that name in new tab
selecting 1st item will search what you're typing in new tab
search input appears in the new tab (but for some reason if you just press enter on it for the first time instead of typing something, it searches with it empty)

Chovin commented 5 years ago

@vaniart, these changes are good with you? there aren't any style changes you think we should add?

Chovin commented 5 years ago

@burdickdr is ok with pushing this live and doing the style changes later. let's get it live!