OJWatson / nomad

Mobility modelling for infetious disease epidemiology
https://ojwatson.github.io/nomad/
Other
1 stars 0 forks source link

mobility S3 Generics PR #19

Open OJWatson opened 7 months ago

OJWatson commented 7 months ago

The generics in mobility also export the base functions (e.g. plot, summary etc), which is non-standard behavior. It's more usual to just export the S3methods and then you dont have to load or use mobility:: in front of these functions.

Also, check can stay as a function, but it is similar to both deviance and plot in nature, and perhaps it would be better to ust have those two as separate S3methods that could use the generics found in base and stats.