search

OLA2022-Group-12 / OLA2022-Project

Project for the Online Learning Applications class at Politecnico di Milano a.a. 2021-2022
2 stars 0 forks source link

Environment additions #19

Closed raul-singh closed 2 years ago

raul-singh commented 2 years ago

Here are the small additions from the alphaless branch, they should be good now!

barskern commented 2 years ago

Seems the formatting failed ☺️

raul-singh commented 2 years ago

Also tests, I'll fix it

raul-singh commented 2 years ago

The formatting error is probably because I'm working on a new device which still has no pre-commit installed, I'lll install it

raul-singh commented 2 years ago

@barskern from what I see the test fails because I used aenum instead of enum :thinking: . To clarify, I moved from Enum to aenum because there was a problem with aliases. What do you think we should do?

barskern commented 2 years ago

@barskern from what I see the test fails because I used aenum instead of enum 🤔 . To clarify, I moved from Enum to aenum because there was a problem with aliases. What do you think we should do?

Hmm what was the problem with aliases?

raul-singh commented 2 years ago

Hmm what was the problem with aliases?

The problem is that we need to have both Step.ONE and Step.TWO to have the same value, but the base Enum works only with unique values.

raul-singh commented 2 years ago

@barskern are you able to fix the test so it doesn't break with the aenum?

barskern commented 2 years ago

There! 😄 Merging