search

OLA2022-Group-12 / OLA2022-Project

Project for the Online Learning Applications class at Politecnico di Milano a.a. 2021-2022
2 stars 0 forks source link

Context generation #28

Closed daviderigamonti closed 1 year ago

daviderigamonti commented 1 year ago

Alas, I managed to make the context generation work. This preliminary pull request only contains the context generation algorithm as I think that it would be good to have some preliminary feedback, after that i intend to tackle on the Contextual Learner which should utilize the algorithm in order to make predictions based on the context. There are still some TODOs that can't really be fixed on the spot since I think they would require some discussion with the group due to their "theoretical meaning" and would be otherwise easy fixes that can be made on master. Even with the Learner still to go and the TODOs I think that the bulk of the work of this step has been done.

barskern commented 1 year ago

This dems great, amazing work. I’ll review the code in detail as soon as possible. Thank you for your patience!—MvhOle Martin Ruud9. nov. 2022 kl. 23:09 skrev Davide Rigamonti @.***>: @davide-rigamonti-polimi requested your review on: #28 Context generation.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

barskern commented 1 year ago

@davide-rigamonti-polimi Do you want feedback as commits roll in or at a later time when you re-request a review?

daviderigamonti commented 1 year ago

@davide-rigamonti-polimi Do you want feedback as commits roll in or at a later time when you re-request a review?

@barskern I think that I'am almost finished with this feature, I'll probably request a new "last" review in these days.