search

OLA2022-Group-12 / OLA2022-Project

Project for the Online Learning Applications class at Politecnico di Milano a.a. 2021-2022
2 stars 0 forks source link

Environment #5

Closed raul-singh closed 2 years ago

raul-singh commented 2 years ago

Environment works as is. Further modifications will be made, like minor refinements and proper testing

raul-singh commented 2 years ago

I managed to fix the major issues and to implement the requested features! A lot of modifications done, the environment works as intended

raul-singh commented 2 years ago

Are the modifications ok with everyone? I’m guessing yes since there are no observations after the last commit and comment I did. Should we approve the PR? Everyone should be able to work using the environment as a base

barskern commented 2 years ago

I will take another look tonight for your changes! Thank you for your effort again. I didn't see the changes until now, if you would tag me with "request review" again when you would want a rereview in the future I think I would get an email so I could give feedback quicker 😊

raul-singh commented 2 years ago

I'm writing this here because it's not a direct reply to a single comment of @barskern but a general reply.I would like to point out one thing. I'm using a lot of tools and methods I didn't know before. As I told you, I have never used python on this level, so basically every request I'm trying to fulfill consists in me researching the tool/tecnique/structure requested, trying it out, seeing the errors it spits out and trying to understand why those errors come out. Like poetry, the rng, the dataclass, pytest, the initialization of complex structures in the dataclass and so on. On top of that, I didn't even know about the existence of named tuples (just as an example). All of this is taking me a lot of times, headackes and debugging. So please, be patient with me. I don't want to make it look lazy, I'm really giving a lot of my time for this, even if I have a thousands of other important things to do, because I care about this.

barskern commented 2 years ago

I'm writing this here because it's not a direct reply to a single comment of @barskern but a general reply.I would like to point out one thing. I'm using a lot of tools and methods I didn't know before. As I told you, I have never used python on this level, so basically every request I'm trying to fulfill consists in me researching the tool/tecnique/structure requested, trying it out, seeing the errors it spits out and trying to understand why those errors come out. Like poetry, the rng, the dataclass, pytest, the initialization of complex structures in the dataclass and so on. On top of that, I didn't even know about the existence of named tuples (just as an example). All of this is taking me a lot of times, headackes and debugging. So please, be patient with me. I don't want to make it look lazy, I'm really giving a lot of my time for this, even if I have a thousands of other important things to do, because I care about this.

@RaulSingh-7 I fully understand that! And I can also understand if this is a big toll on you in that sense. I really do not wish to cause a headache or extra work, though I do think perhaps many of the concepts and tools are very helpful to learn. We have a limited amount of time for the project, and I also am fully aware that you have other obligations for other subjects and life in general. I know I might be a bit demanding in my comments, which I know is perhaps related to my perfectionism in that regard. Maybe I am being too nickpicky for this type of project.

In essence I am not quite sure how to proceed perhaps. Do you feel like this is too much in comments in that regard and that we should rather try to quickly work towards a solution to solve the "project", or would you want to continue this process as-is?

(To add to that, I have no issue with being patient in that regard. I don't want to tell you what to do in the sense that I want this to remain a group project where we all decided. Though I know I may be imposing my views and opinions strongly)

barskern commented 2 years ago

Add a commit with some testing for the alpha function, I hope its okay!

barskern commented 2 years ago

@RaulSingh-7 I think the last changes you made now are just perfect! We haven't work with this code yet in the other parts of the program, but I do believe now that it will be both easy and nice. I really appriciate the effort you put into this, and I know you put a lot of hours. Thank you so much for your hard work!

barskern commented 2 years ago

Also last thing, regarding testing. We can add some tests at a later point in a later pull request. Lets get this merged!