The LAN Import Plugin doesn't get built

OLSR / OONF

OLSR.org Network Framework - olsrd v2 / DLEP

55 stars 36 forks source link

The LAN Import Plugin doesn't get built #47

Open jpo-github-work opened 2 years ago

jpo-github-work commented 2 years ago

This is the current src/olsrv2/CMakeLists.txt:

# add subdirectories
add_subdirectory(netjsoninfo)
add_subdirectory(olsrv2)
add_subdirectory(olsrv2info)
add_subdirectory(olsrv2_old_lan)
add_subdirectory(olsrv2_l2import)
add_subdirectory(olsrv2_lan)
add_subdirectory(route_modifier)

Is there a reason that lan_import is missing? It's still documented in the Wiki...

jpo-github-work commented 2 years ago

See #48 for an obvious fix

jpo-github-work commented 2 years ago

@mathiashro Can you merge this? It cannot create a bug...

mathiashro commented 2 years ago

Is there a reason that lan_import is missing? It's still documented in the Wiki...

May be @HRogge has some spare time to answer.

@mathiashro Can you merge this? It cannot create a bug...

Done.

Leaving the case open for some time to gather further comments / community feedback.

jpo-github-work commented 2 years ago

@HRogge @mathiashro The merged patch is either incorrect or incomplete. It should either be reverted or needs pull request #51 to resolve a duplicated symbol issue. The relevant change is the following rename (+ updates to references):

-static struct oonf_subsystem _import_subsystem = {
+static struct oonf_subsystem _olsrv2_lan_import_subsystem = {