search

OMGSoundboard / android-app

OMGSoundboard Android App
https://omgsoundboard.audio/
Apache License 2.0
28 stars 4 forks source link

F-Droid build failed #109

Open linsui opened 1 month ago

linsui commented 1 month ago

:writing_hand: Describe the bug

https://gitlab.com/fdroid/fdroiddata/-/jobs/8017535739 The wear os deps are not FOSS. Could you please provide a FOSS flavor for F-Droid? Thanks!

:bomb: Steps to reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

:wrench: Expected behavior

:camera: Screenshots

:iphone: Tech info

:page_facing_up: Additional context

OMGSoundboard commented 1 month ago

Thanks for reporting the issue, @linsui. May you simply ignore the whole wear folder?

licaon-kter commented 1 month ago

Isn't that tied in the main code?

OMGSoundboard commented 1 month ago

Isn't that tied in the main code?

No, the smartwatch Wear OS by Google part is independent from the smartphone part. Am I wrong, @Rashxz?

linsui commented 1 month ago

It's not that case anymore. https://github.com/OMGSoundboard/android-app/pull/100 added wear related features in the main app.

Rashxz commented 1 month ago

Isn't that tied in the main code?

No, the smartwatch Wear OS by Google part is independent from the smartphone part. Am I wrong, @Rashxz?

The main app also has the wear play services library to comunicate and sync data. I'll make a flavor to leave that part out.

OMGSoundboard commented 2 weeks ago

May you please try if v13.0 builds again on F-Droid, @linsui?

linsui commented 2 weeks ago

https://github.com/OMGSoundboard/android-app/blob/v13.0/core/build.gradle#L48 This is not FOSS. Could you please remove this from foss flavor?

Rashxz commented 2 weeks ago

https://github.com/OMGSoundboard/android-app/blob/v13.0/core/build.gradle#L48 This is not FOSS. Could you please remove this from foss flavor?

Forgot that was there sorry. Removed.

linsui commented 2 weeks ago

https://github.com/OMGSoundboard/android-app/blob/v13.0/sync_manager/build.gradle#L54 This lib depends on GMS.

Rashxz commented 1 week ago

https://github.com/OMGSoundboard/android-app/blob/v13.0/sync_manager/build.gradle#L54 This lib depends on GMS.

moved, do you see any other lib that is not foss?

linsui commented 1 week ago

No, it should be good now. :)

OMGSoundboard commented 1 week ago

I created a new release and hope it builds now. 🫡

linsui commented 1 week ago

https://github.com/OMGSoundboard/android-app/blob/development/core/build.gradle#L44 I didn't notice this, sorry... Could you please also remove it?

Rashxz commented 1 week ago

Removed

OMGSoundboard commented 4 days ago

I created a new release and hope it builds now. 😀

licaon-kter commented 4 days ago

still fails: https://gitlab.com/fdroid/fdroiddata/-/jobs/8342676205#L658

diff log: omg17.log

IzzySoft commented 4 days ago

v17.0 fails RB at IzzyOnDroid as well btw, with a huge diff in classes2.dex: diffs.zip

Do you still build with JDK-17 as your workflow states? Well, results with JDK-21 were identical, so that's not it. Built from a clean tree – or any local changes/artifacts/caches?

OMGSoundboard commented 3 days ago

I suppose @Rashxz is already looking into it. I have no clue at the moment, sorry.

IzzySoft commented 2 days ago

Fingers crossed then! As discussed on "the other channel", v17.0 is marked "RB failed" now (afraid we cannot "rescue" that one) – but that "mark" will age out with future releases hopefully matching up again :crossed_fingers: