search

OMOSde / contao-om-backend

Additional backend tools for Contao 4.4+
GNU Lesser General Public License v3.0
19 stars 5 forks source link

Fix dependencies for Contao 4.11 #62

Closed stefansl closed 3 years ago

stefansl commented 3 years ago

I had to downgrade the multicolumn-wizard for compatibility reasons, see https://github.com/menatwork/contao-multicolumnwizard-bundle/issues/107

Maybe it's a good idea to merge this PR into an own branch (e.g. hotfix-c4.11). I did not test in Contao < 4.11

OMOSde commented 3 years ago

Thanks for the PullRequest.

I can test the update to htmlpagedom ^2 with Contao 4.4 and 4.9.

Regarding 'menatwork/contao-multicolumnwizard-bundle' I don't think that a downgrade in 'omosde/contao-om-backend' to a no longer maintained bundle is the solution. The problem should be fixed at the source.

Alternatively, a conflict can be entered in composer.json (root) for '"symfony/http-kernel":"^5"' (thanks goes to Fritz: https://github.com/menatwork/contao-multicolumnwizard-bundle/issues/107#issuecomment-803645107). This will switch from Symfony v5 to v4. Contao 4.11 is compatible with v4 and v5 and the conflict can be removed later if possible.

stefansl commented 3 years ago

Of course, downgrading multicolumnwizard is not a permanent solution. But it's working as a hotfix for 4.11

I hope, they fix it in the source, soon :)

OMOSde commented 3 years ago

Please use the conflict-solution for your installation.

stefansl commented 3 years ago

In my case I just cloned my forked repo and adjusted my composer.json. Because I want to keep SF5 for severeal reasons.

OMOSde commented 3 years ago

I close this PR, because the solution is not the right approach for this bundle. Thanks anyway.