OMS-NetZero / FAIR

Finite-amplitude Impulse Response simple climate model
https://docs.fairmodel.net
Apache License 2.0
130 stars 62 forks source link

Merge changes from multi_gas (v1.1) #1

Closed chrisroadmap closed 6 years ago

chrisroadmap commented 6 years ago

I have integrated the changes from the FAIR-pro repository into a new branch (branch_1.1.0) which is consistent with the latest development version on FAIR-pro (I have run the model for a 1000 member ensemble and verified that the results are the same). The only difference is that I have retained the additional data from v1.0.0 in the Miller-et-al directory which was not present in my development version.

It would be good to get this released as FAIR as v1.1.0 which is as described in https://www.geosci-model-dev-discuss.net/gmd-2017-266/ . The code has been requested to be released, which is strongly encouraged for GMD model description papers.

Zeb, I hope you don't mind that you weren't included as an author on the paper. It seems that our PIs decided to work on FAIR independently - I wrote an entire model in parallel based on a very early version, found out that FAIR v1.0 existed already, and then had to rewrite everything to ensure back-compatibility!

znicholls commented 6 years ago

No stress on authorship, I have had nothing to do with FAIR1.1 so would have been surprised had I been on there! I hope making it backward compatible wasn't too painful...

My only clarifying question, what are you referring to when you say 'latest development version on FAIR-pro'?