OMS-NetZero / FAIR

Finite-amplitude Impulse Response simple climate model
https://docs.fairmodel.net
Apache License 2.0
121 stars 61 forks source link

Update CHANGELOG.rst #105

Closed chrisroadmap closed 2 years ago

chrisroadmap commented 2 years ago

Adds SSP module interface

CHANGELOG bumped to v1.6.4

codecov[bot] commented 2 years ago

Codecov Report

Merging #105 (e1d7d11) into master (f5b884f) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files          40       40           
  Lines        1679     1679           
=======================================
  Hits         1598     1598           
  Misses         81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3cdd410...e1d7d11. Read the comment docs.

patternizer commented 2 years ago

Hi Chris,

I've installed v1.6.4 and am trying to run the SSPs (ssp119, ssp126, ssp245, ssp370. ssp585). I am getting an unknown location traceback error in the SSP Scenarios block of examples.ipynb:


ImportError Traceback (most recent call last)

in 1 # Get RCP modules ----> 2 from fair.SSPs import ssp126, ssp245, ssp370, ssp585 3 4 # Basic RCP runs 5 C126, F126, T126 = fair.forward.fair_scm(emissions=ssp126.Emissions.emissions) ImportError: cannot import name 'ssp126' from 'fair.SSPs' (unknown location) ------------------------------------------------------------------------------------------------------------------------ The rest of the notebook doesn't have any issues. Is this a path issue in __init__.py in the /fair/SSPs call ? Thanks ! Best wishes, Michael
chrisroadmap commented 2 years ago

@patternizer which version of python are you using? This works for me on 3.9:

from fair.SSPs import ssp126
import fair
c,f,t = fair.forward.fair_scm(emissions=ssp126.Emissions.emissions)

it is tested on all 3.6 to 3.9; anecdotally 3.5 also causes no issues. I had to drop support for 2.7 as some of the module dependencies were broken.

patternizer commented 2 years ago

@chrisroadmap hi Chris. I'm using Python 3.8.11. I got it to work by running make Makefile. That looks like it has fixed the paths and I can now run the forward models no problem. Thanks, Michael