OMS-NetZero / FAIR

Finite-amplitude Impulse Response simple climate model
https://docs.fairmodel.net
Apache License 2.0
120 stars 61 forks source link

Sulfur forcing #124

Closed saraarriz closed 1 year ago

saraarriz commented 1 year ago

Describe the bug

When inputting sulfur emissions in FAIR, I don't get any output as sulfur forcing. I have tried the [basic_run_example.ipynb] code, which is available in the github, and I still have no response for sulfur forcing. After running FAIR, this is what I get :

Failing Test

  f.emissions.loc[dict(specie='Sulfur')]

   array([[[100.        , 100.        , 100.        ],
    [  2.2       ,   2.2       ,   2.2       ]],

   [[100.        , 100.        , 100.        ],
    [  4.19591837,   4.19591837,   4.19591837]],

   [[100.        , 100.        , 100.        ],
    [  6.19183673,   6.19183673,   6.19183673]],

   [[100.        , 100.        , 100.        ],
    [  8.1877551 ,   8.1877551 ,   8.1877551 ]],

   [[100.        , 100.        , 100.        ],
    [ 10.18367347,  10.18367347,  10.18367347]],

   [[100.        , 100.        , 100.        ],
    [ 12.17959184,  12.17959184,  12.17959184]],

   [[100.        , 100.        , 100.        ],
    [ 14.1755102 ,  14.1755102 ,  14.1755102 ]],
    ...
   [[100.        , 100.        , 100.        ],
    [ 88.0244898 ,  88.0244898 ,  88.0244898 ]],

   [[100.        , 100.        , 100.        ],
    [ 90.02040816,  90.02040816,  90.02040816]],

   [[100.        , 100.        , 100.        ],
    [ 92.01632653,  92.01632653,  92.01632653]],

   [[100.        , 100.        , 100.        ],
    [ 94.0122449 ,  94.0122449 ,  94.0122449 ]],

   [[100.        , 100.        , 100.        ],
    [ 96.00816327,  96.00816327,  96.00816327]],

   [[100.        , 100.        , 100.        ],
    [ 98.00408163,  98.00408163,  98.00408163]],

   [[100.        , 100.        , 100.        ],
    [100.        , 100.        , 100.        ]]])

    f.forcing.loc[dict(specie='Sulfur')]

    array([[[ 0.,  0.,  0.],
    [ 0.,  0.,  0.]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],
    ...
   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]],

   [[nan, nan, nan],
    [nan, nan, nan]]])

Expected behavior

Here, I expected the corresponding values of sulfur forcing as a response of the emissions.

System (please complete the following information):

Additional context

I am a trainee student in Airbus and I am doing my master's thesis in aviation impact on climate.

chrisroadmap commented 1 year ago

Hi, this is not a bug: the Sulfur species does not itself create a forcing, it is a precursor of ERFari (direct aerosol forcing) and ERFaci (indirect aerosol forcing).

f.forcing.loc[dict(specie='ERFari')] f.forcing.loc[dict(specie='ERRaci')]

will work.

saraarriz commented 1 year ago

Thank you very much for your prompt response.

Sara Arriolabengoa

On Tue, Jun 20, 2023 at 9:00 AM Chris Smith @.***> wrote:

Hi, this is not a bug: the Sulfur species does not itself create a forcing, it is a precursor of ERFari (direct aerosol forcing) and ERFaci (indirect aerosol forcing).

f.forcing.loc[dict(specie='ERFari')] f.forcing.loc[dict(specie='ERRaci')]

will work.

— Reply to this email directly, view it on GitHub https://github.com/OMS-NetZero/FAIR/issues/124#issuecomment-1598220997, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6Q6VJVNY7AJICGIKZOZFD3XMFDCLANCNFSM6AAAAAAZLTMNDE . You are receiving this because you authored the thread.Message ID: @.***>

The information in this e-mail is confidential. The contents may not be disclosed or used by anyone other than the addressee. Access to this e-mail by anyone else is unauthorised. If you are not the intended recipient, please notify Airbus immediately and delete this e-mail. Airbus cannot accept any responsibility for the accuracy or completeness of this e-mail as it has been sent over public networks. If you have any concerns over the content of this message or its Accuracy or Integrity, please contact Airbus immediately. All outgoing e-mails from Airbus are checked using regularly updated virus scanning software but you should take whatever measures you deem to be appropriate to ensure that this message and any attachments are virus free.