search

OMS-NetZero / FAIR

Finite-amplitude Impulse Response simple climate model
https://docs.fairmodel.net
Apache License 2.0
120 stars 61 forks source link

`pooch` is not downloading from DOIs #137

Closed chrisroadmap closed 9 months ago

chrisroadmap commented 9 months ago

pooch is not downloading from DOIs. This affects data inside the fair code that is downloaded externally using a pattern with doi: such as

rcmip_emissions_file = pooch.retrieve(
    url="doi:10.5281/zenodo.4589756/rcmip-emissions-annual-means-v5-1-0.csv",
    known_hash="md5:4044106f55ca65b094670e7577eaf9b3",
)

The file downloads correctly using the full URL, https://zenodo.org/records/4589756/files/rcmip-emissions-annual-means-v5-1-0.csv

This breaks fill_from_rcmip() and fails unit tests.

It appears that this is a known issue in pooch, which looks like it will be patched: https://github.com/fatiando/pooch/issues/371

Question is whether to bugfix fair and point to https rather than doi addresses for Zenodo.