search

OMS-NetZero / FAIR

Finite-amplitude Impulse Response simple climate model
https://docs.fairmodel.net
Apache License 2.0
123 stars 63 forks source link

Start using versioneer #2

Closed znicholls closed 6 years ago

znicholls commented 6 years ago

The way we're doing things at the moment is not the smartest I don't think. Given how slow development is it's not really an issue but versioneer seems to be a good option if it does become an issue.

https://github.com/warner/python-versioneer

chrisroadmap commented 6 years ago

I've added a branch (add_versioneer) in which I've set up versioneer. It appears to work. I think that each developer would need to install versioneer themselves locally, but once done my understanding is that it should automatically tag revisions once changes are committed. Let me know if you're happy to merge in.

znicholls commented 6 years ago

If we add versioneer as a dependency in setup.py would we skip the need for people to think about installing versioneer locally i.e. it would happen automatically?

chrisroadmap commented 6 years ago

It's my understanding that users don't need to install it as it lives in the setup script. Actually, once it's in place and configured I'm not sure developers need to install it locally either as I think versioneer.py handles the version tagging automatically.

znicholls commented 6 years ago

Ah ok yes I understand. I think you're right. I'd also be very surprised if there weren't a way to specify which modules developers need.

chrisroadmap commented 6 years ago

Done and merged into master.