search

OMS-NetZero / FAIR

Finite-amplitude Impulse Response simple climate model
https://docs.fairmodel.net
Apache License 2.0
123 stars 62 forks source link

Unify indentation #27

Closed rgieseke closed 6 years ago

rgieseke commented 6 years ago

Hi, FAIR is currently using a mix of tabs, 2 and 4 spaces -- this is something I usually try to fix when going through a codebase which I'm trying to understand.

This PR unifies indentation to 4 spaces and improves PEP8 compliance in fair/forward.py.

Let me know if this not useful for you (or not at the moment)! Part of my motivation for adding more tests (#24) was also to be able to do such unification with more confidence ...

chrisroadmap commented 6 years ago

@rgieseke - completely agree. I think this is the only file where indentation is 2 spaces. The code has changed a bit since this original pull request (sorry I've left it so long), so trying to resolve conflicts at this stage is a bit confusing. I'll close this pull request but fix the indentation in the master.