v1.3 dev - Githubissues

OMS-NetZero / FAIR

Finite-amplitude Impulse Response simple climate model

https://docs.fairmodel.net

Apache License 2.0

123 stars 62 forks source link

v1.3 dev #31

Closed chrisroadmap closed 6 years ago

chrisroadmap commented 6 years ago

Merge in changes ready for submission of v1.3 model description paper.

Aerosol ERFari defaults changed following second review of GMD paper - now follow Myhre et al. 2013 exactly for all except black carbon, which is reduced in radiative efficiency to take into account semi-direct effect only really due to BC and not other species.
Land use and aviation contrail forcing can be specified directly (does not have to rely on cumulative CO2 or aviation fraction of total NOx)
time varying scale factor for matching with AR5 has been modified in light of the new aerosol forcing.

No actual science changes compared to v1.2.3, just a new default setup, which probably justifies incrementing the model version.

znicholls commented 6 years ago

@chrisroadmap I think incrementing the version is correct. However, given these changes are backwards incompatible (as all the defaults change), in a world where we have outside users I think we'd actually be meant to increment to v2.0.0. Check out https://semver.org/ and https://www.python.org/dev/peps/pep-0440/#version-scheme

chrisroadmap commented 6 years ago

@znicholls Sorry for my clumsiness here. Given that I'm not sure how big the user base is currently, and for reasons of consistency, I'd like to keep this as 1.3 (defaults have been changing since 1.1) but this kind of change will be a major increment in the future.

znicholls commented 6 years ago

No stress, I also had no idea until I stumbled upon those sites! Sounds good, good luck with v1.3 publication.

On 9 May 2018, at 01:33, chrisroadmap notifications@github.com wrote:

@znicholls Sorry for my clumsiness here. Given that I'm not sure how big the user base is currently, and for reasons of consistency, I'd like to keep this as 1.3 (defaults have been changing since 1.1) but this kind of change will be a major increment in the future.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.