Closed nsfmc closed 11 months ago
if this isn't useful to the project or if it introduces a level of complexity you'd rather not deal with, please feel free to close this pr, mostly submitted to see if it was useful to anybody else.
Merging #53 into master will decrease coverage by
9.87%
. The diff coverage is61.73%
.
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 90.78% 80.91% -9.88%
==========================================
Files 33 34 +1
Lines 1270 1074 -196
==========================================
- Hits 1153 869 -284
- Misses 117 205 +88
Impacted Files | Coverage Δ | |
---|---|---|
fair/RCPs/rcp60.py | 100% <100%> (ø) |
:arrow_up: |
fair/RCPs/rcp85.py | 100% <100%> (ø) |
:arrow_up: |
fair/RCPs/rcp26.py | 100% <100%> (ø) |
:arrow_up: |
fair/RCPs/rcp45.py | 100% <100%> (ø) |
:arrow_up: |
fair/RCPs/types.py | 58.87% <58.87%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9e5b197...3b45e51. Read the comment docs.
definitely moves in the right direction for v2.0 @chrisroadmap
closing as part of general clean and moved beyond this treatment in v2 - thanks all the same :+1:
hahaha @chrisroadmap i have zero memory of doing this (it was clearly another time), thanks for closing it out all the same 🤘🏽
the classes simplify the rcp_.py files while providing a consistent interface to the data when ingesting arbitrary rcp csv files (i.e. useful in cases where you don't want or need to import all three Emissions/Concentrations/Forcings)
also useful in cases where you need to override specific property behavior (i.e. scaling or reformatting some specific property dynamically)
this subclassed
Forcing
would no longer emit an ndarray for years, but instead a simple python list ofint
s. This is an pretty contrived example, but i think fairly illustrative.The goal here was to maintain api parity while adding some minor functionality. Tests pass at the same rate as before.
specific additions:
._filename
is exposed__repr__
exposes an Emission/Concentration/Forcing's source filename as well.Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: