search

OMS-NetZero / FAIR

Finite-amplitude Impulse Response simple climate model
https://docs.fairmodel.net
Apache License 2.0
123 stars 62 forks source link

Add gases field to other RCPs #54

Closed rgieseke closed 5 years ago

rgieseke commented 5 years ago

This adds a gases to the other RCPs - atm only RCP45 has one. Thus only with RCP45 the concentration-driven example works.

There might be better ways to do this (inheritance?) but this should do the trick ...

codecov[bot] commented 5 years ago

Codecov Report

Merging #54 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #54      +/-   ##
=========================================
+ Coverage   92.46%   92.5%   +0.03%     
=========================================
  Files          36      36              
  Lines        1328    1334       +6     
=========================================
+ Hits         1228    1234       +6     
  Misses        100     100
Impacted Files Coverage Δ
fair/RCPs/rcp60.py 100% <100%> (ø) :arrow_up:
fair/RCPs/rcp85.py 100% <100%> (ø) :arrow_up:
fair/RCPs/rcp26.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4d78ec...82d1024. Read the comment docs.

rgieseke commented 5 years ago

I've added a version requirement for pytest - this might be helpful for other PRs too. I think the default version on Travis image is too low.

chrisroadmap commented 5 years ago

Nice spot @rgieseke - and the age of this PR hints at the kind of lead time we are working on at the moment!