OMS-NetZero / FAIR

Finite-amplitude Impulse Response simple climate model
https://docs.fairmodel.net
Apache License 2.0
123 stars 62 forks source link

Make iirf_h a keyword parameter (formerly fixed at 100 years) #58

Closed chrisroadmap closed 5 years ago

chrisroadmap commented 5 years ago

Pull request

Please confirm that this pull request has done the following:

Fixes #4.

codecov[bot] commented 5 years ago

Codecov Report

Merging #58 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #58      +/-   ##
=========================================
+ Coverage   91.88%   91.9%   +0.01%     
=========================================
  Files          33      33              
  Lines        1269    1272       +3     
=========================================
+ Hits         1166    1169       +3     
  Misses        103     103
Impacted Files Coverage Δ
fair/forward.py 83.88% <100%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0517852...faeb7b6. Read the comment docs.

chrisroadmap commented 5 years ago

No rush on this one @znicholls

znicholls commented 5 years ago

Can you rebase onto master? It seems to be including changes from #57 too.

chrisroadmap commented 5 years ago

Yep, #57 was merged into master previously so the new branch includes these changes (git rebase confirms this branch is up to date with master). I've just made a small patch to the changelog and squashed it into the previous commit.

chrisroadmap commented 5 years ago

Awesome. Will merge when back in office next week. I don't think the 100 year time horizon was ever meant to be modified but gives users another dial they can crank. For consistency r0 and possibly also rc and rt would need to be modified as they are defined with respect to a 100 year time horizon.