Closed znicholls closed 4 years ago
You might see a way to speed things up, but this works.
@chrisroadmap thinking about it more, would it be simpler if we moved the scmdf_to_emissions
function into climate-assessment?
@chrisroadmap thinking about it more, would it be simpler if we moved the
scmdf_to_emissions
function into climate-assessment?
nah, leave it here, another interface possibility and we'll be ready for scmdata
world domination
beauno hopefully this scmdata makes more sense now you've seen it in action...
just ye, check the units...
You might see a way to speed things up, but this works.
This takes 4 seconds per scenario for me :(
This takes 4 seconds per scenario for me :(
Yep. There's ways to speed it up but I felt that working out what is going on first (and making sure it gives the right numbers) was priority, with optimisation coming thereafter.
If you get it working how you want, I'll speed it up tomorrow
The aerosol problem was nonsensical defaults in openscm_runner
, so this branch is numerically fine I think. Just needs a 40x speedup...
The aerosol problem was nonsensical defaults in
openscm_runner
, so this branch is numerically fine I think. Just needs a 40x speedup...
Beauty. Keep in mind that this only has to happen once per scenario in openscm_runner
so if it takes 1 second (which yes is 4x speedup but I don't think that'll be crazy difficult), it's not so much compared to the 600 model runs?
The aerosol problem was nonsensical defaults in
openscm_runner
, so this branch is numerically fine I think. Just needs a 40x speedup...Beauty. Keep in mind that this only has to happen once per scenario in
openscm_runner
so if it takes 1 second (which yes is 4x speedup but I don't think that'll be crazy difficult), it's not so much compared to the 600 model runs?
Yeah, true. It does make testing a bit of a pain in the ass. If you can make it faster then great but put it as low priority.
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedAdding to CHANGELOG.rst
Please add a single line in the changelog notes similar to one of the following: