search

ON4QZ / QSSTV

Receive and transmit images over radio using analog SSTV or digital DRM
GNU General Public License v3.0
83 stars 10 forks source link

RS Encoding/Decoding only allows for three letter extensions #18

Open westjgames opened 1 year ago

westjgames commented 1 year ago

The current version of this software only allows for sending three letter file extensions, which causes the receiving software to get a truncated file name.

image.avif => image.avi

With my local nets increasingly switching to AVIF image format to send high-definition images in 50kb, this causes issues as the files end up needing to be renamed, which is a hassle for some people on Windows who cannot see the extension and get very confused.

reedSolomonCoder::encode seems hardcoded to pad to three characters only, truncating anything longer.

Ruxton commented 1 year ago

Can you give me some more info:

What settings are you using when sending? Does setting RS to None solve the issue?

westjgames commented 1 year ago

I usually use the TX File option. You can use any DRM setting with RS, it will still truncate the extension. Turning off RS does allow the four letter extension through.

I’ve played with the RS code myself quite a bit and managed to get four letter extensions through, but then three letter file extensions would result in corrupted files. I’m absolutely trash at C++ to be clear though.

Ruxton commented 1 year ago

@westjgames i've got to a compile that is receiving any length extension from EasyPal and sending 3-4 extensions fine. I haven't managed to get it to send much longer just yet, but i'll probably get it sorted. I also think there is high potential for implemting libAVIF in QSSTV, but lets not get ahead of ourselves.

westjgames commented 1 year ago

Honestly, would absolutely love to see libAVIF but you’re absolutely right, one step at a time :) Thanks heaps for taking a look at this. It means a lot to me and my Linux HAM friends