ONDC-Official / v1.1.0-logs

2 stars 107 forks source link

Zeitgeist Retail - compliance check #273

Open sandeepshahi opened 1 year ago

sandeepshahi commented 1 year ago

Flow 1

/on_search

/on_select

/on_init

/on_confirm

/on_status (Completed)

/on_update

Flow 2

Flow 4

Check Flow 2,3 4,5 for similar issues raised in Flow 1

@Rajathkunder

sandeepshahi commented 1 year ago

Common Issues

/on_search

/on_select

/on_confirm

/on_status

/on_update (Liquidated)

Flow 2

/on_search

/on_confirm

/on_cancel

Flow 4

/on_select

@Rajathkunder

sandeepshahi commented 1 year ago

Common Issues

/on_search

/on_select

/on_init

/on_confirm

/on_status

/on_update (Initiated)

Flow 5

@SudarshanSirsi

SudarshanSirsi commented 1 year ago

Hello, I just wanted to understand some things regarding quote/breakup/price and tax.

  1. In /on_select I just wanted to confirm that what you mean is quote.breakup.price.value = item_price +tax_value Where tax value is -> { "@ondc/org/item_id": "435", "title": "Tax", "@ondc/org/title_type": "tax", "price": { "currency": "INR", "value": "10" } }

AND

  1. If suppose, for some products, if MRP includes all taxes also, then the below object for tax in quote/breakup is mandatory?

    { "@ondc/org/item_id": "435", "title": "Tax", "@ondc/org/title_type": "tax", "price": { "currency": "INR", "value": "10" } }

  2. Regarding "invalid format of item code in /bpp/providers/items/descriptor/code" in /on_search , For /bpp/providers/items/descriptor/code, if we use the HSN code as mentioned in V.1.1.0 API contract is that acceptable? Because The HSN values would not be unique for every individual product, but they may be unique for a category. Please correct me wherever I am wrong @bluecypher Thank You.

sandeepshahi commented 1 year ago

Common Issues

/on_search

/on_confirm

/on_update

Flow 3

/on_update

Flow 5

/on_select

@SudarshanSirsi